Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async fix #550

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Async fix #550

wants to merge 1 commit into from

Conversation

atesgoral
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

@atesgoral atesgoral mentioned this pull request Nov 28, 2024
Open
atesgoral
atesgoral commented Nov 28, 2024
View reviewed changes
Gemfile
@@ -3,6 +3,7 @@ source "https://rubygems.org"
# Include gem dependencies from ruby-openai.gemspec
gemspec

gem "async-http-faraday", "~> 0.19.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't be part of gem deps, but will solely be used in tests.

atesgoral
atesgoral commented Nov 28, 2024
View reviewed changes
lib/openai/client.rb
@@ -12,6 +12,7 @@ class Client
uri_base
request_timeout
extra_headers
async
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New config option

atesgoral
atesgoral commented Nov 28, 2024
View reviewed changes
lib/openai/http.rb
@@ -78,6 +78,7 @@ def conn(multipart: false)
f.use MiddlewareErrors if @log_errors
f.response :raise_error
f.response :json
f.adapter :async_http if @async
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require users to include async-http-faraday in their app themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@atesgoral