moving to babel 7 #34
Conversation
|
I am having some issues with jest. @TrySound have you come across this before? |
|
It looks like I am running into this: jestjs/jest#6364 You got past it for react-beautiful-dnd ... |
|
Worst part is that this is now working on my local :| |
|
In the edge the babel-core bridge was needed to get jest to run |
rollup.config.js
Outdated
| '@babel/preset-env', | ||
| { | ||
| 'targets': { | ||
| 'esmodules': true, |
There was a problem hiding this comment.
Every user who bundle their code will be forced to transpile this package.
There was a problem hiding this comment.
Do you really want to start distribution of es6 code?
There was a problem hiding this comment.
I have taken this out
rollup.config.js
Outdated
| @@ -45,7 +45,19 @@ export default [ | |||
| file: 'dist/memoize-one.esm.js', | |||
| format: 'es', | |||
|
commonjs plugin can be removed |
.babelrc
Outdated
| ] | ||
| }, | ||
| "test": { | ||
| "plugins": [ | ||
| "transform-es2015-modules-commonjs" | ||
| "@babel/plugin-transform-modules-commonjs" |
There was a problem hiding this comment.
this env section with transform-modules-commonjs can be removed since env is already includes this. The point is that rollup/webpack plugins are able to add modules option internally. This allows to simplify config.
.babelrc
Outdated
| "flow", | ||
| ["env", { "modules": false, "loose": true }] | ||
| "@babel/preset-flow", | ||
| ["@babel/preset-env", { |
There was a problem hiding this comment.
You may omit preset and plugin words to make this config shorter.
|
I recommend to use babel.config.js everywhere. It's more straightforward. |
|
Yes, jest will be able to upgrade only with major release. jest 24 will work with babel 7 |
No description provided.