Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for custom equality function with multiple arguments to README #29

Merged
merged 2 commits into from
Aug 7, 2018

Conversation

andwilley
Copy link
Contributor

I'm probably the only one who didn't immediately understand this, but coming right from lodash memoize to this it took me a second to realize that the custom equality function isn't passed all of the arguments at once. It was apparent after looking at the source, but I thought the README could use a word or two about it.

Thank you for this!

Copy link
Owner

@alexreardon alexreardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers!

@alexreardon alexreardon merged commit 58fb93b into alexreardon:master Aug 7, 2018
@andwilley andwilley deleted the cust-eq-mult-args-readme branch August 19, 2018 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants