Using new Scala 3 language features #682
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#393
Changes
enum
where possibleusing
where possiblegiven
where possible. I had to keep usingimplicit val
andimplicit def
in several places becausegiven
seems to invoke the scala 3 lazy val implementation, which invokessun.misc.unsafe
, which requires extra security permissions in Elasticsearch. This is covered in Runtime code implementing lazy val should not use sun.misc.Unsafe on Java 9+ (JEP-471) scala/scala3#9013 and it's a variant of same issue I encountered in Dependencies: Upgrade Scala to 3.3.3 #653Conversion
where possible.trait
that we were no longer using, and aTry
wrapper in several places that just ends up using.get
, a type check that was getting called for every iteration of a while loop.Testing and Validation
Standard CI and benchmarking