Switch from sun.misc.Unsafe to java.nio.ByteBuffer for vectoer (de-)serialization (forwards and backwards compatible) #608
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#263
Changes
Migrating vector serialization functions from
sun.misc.Unsafe
tojava.nio.ByteBuffer
.The new serialization and deserialization are both compatible with sun.misc.Unsafe, so users do not need to worry about re-indexing when they make an upgrade.
The motivations for this switch are:
Micro benchmarks show the new functions are roughly as fast or faster across the board:
The only one that's slower is
readInt
, but that is only used in tests anyways.The ann-benchmarks also look good:
Testing and Validation
Standard CI and JMH benchmarking. New unit tests also verify forwards/backwards compatibility with the old serialization format.