Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI Failures by Adding User-Agent Header to node:https get method #76

Closed
wants to merge 2 commits into from
Closed

Fix CI Failures by Adding User-Agent Header to node:https get method #76

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24a0c85
Fix CI(benchmark) error
Henry-Hong Aug 2, 2024
6285808
Fix user-agent more detailed
Henry-Hong Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/size.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ let { bold, gray } = require("../picocolors.js")

async function getJSON(url) {
return new Promise(resolve => {
get(url, res => {
get(url, { headers: {"user-agent": 'picocolors'} },res => {
Copy link

@styfle styfle Aug 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
get(url, { headers: {"user-agent": 'picocolors'} },res => {
get(url, { headers: {"user-agent": 'picocolors-size-benchmark'} },res => {

Let’s be more specific since picocolors doesn’t make API calls during runtime, only during this benchmark.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That make sense. Here's commit you ordered! 6285808

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexeyraspopov

Sorry to tag you, but can you check this PR please? Thanks.

let text = ""
res.on("data", chunk => {
text += chunk
Expand Down
Loading