-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot extend editor.ui.view template #5
Comments
… raises log messages if it cant support the given editor.
Pull request #6 failed to rectify the problem. More work will be needed to find an appropriate state method for extending the editable view. |
PR's related to ckeditor/ckeditor5#1150 will resolve this issue. Some editor's would call methods that render their |
I merged all PRs related to ckeditor/ckeditor5#1150. Again, huge thanks for your contribution! 👏 I hope you can take your plugin to the next level now! 🚀🚀🚀 |
Note: To anyone running CK v11.0 and experiencing issues with variables in editors other than |
Fixes issue #5 for extending editor.ui.view template
With the release of CKEditor v11.1 comes the changes needed in the editors to fix this issue. Please see the updated README for updated information on the implementation of this plugin. |
editor.ui.view
is not directly extendable as an editor may not define its template in that view alone. AnEditorUIView
subclass may be a container which references several distinct child views which may or may not be structurally contained within this view in the DOM, or if the view has a DOM element at all. This was a misunderstanding based upon an incorrect test environment.The
ClassicTestEditor
initialises the editor differently to a non-testClassicEditor
, rendering before its supposed to. Moreover, the structure of this test editor lead to a misunderstand of what a typical editor structure is and what view is available to have its template extended. This issue is being resolved in ckeditor5-core#137.However, the plugin must be more resilient to handle the very rare case where a new or updated editor class does not have a known view to extend.
The text was updated successfully, but these errors were encountered: