Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

Reverted to 0.1 #89

Merged
merged 3 commits into from
Apr 11, 2018
Merged

Reverted to 0.1 #89

merged 3 commits into from
Apr 11, 2018

Conversation

seunlanlege
Copy link

I've gotten it to compile on the latest nightly compiler, but uhm yeah. The test crate is failing. with cryptic errors

@seunlanlege
Copy link
Author

seunlanlege commented Apr 10, 2018

closing in favour of #88

Looks like #88 is for futures 0.2
this is for 0.1

@seunlanlege
Copy link
Author

@withoutboats can you take a look at travis?

@withoutboats
Copy link
Collaborator

I think this is a problem with the most recent version of the library testcrate uses, we need to change our .travis.yml to run cargo clean between testing the main crate and testcrate.

@seunlanlege
Copy link
Author

Ok so cargo clean allows the test crate to compile but recent changes to rustc as regards to error messages practically invalidates all the stderr assertion checks, I'll try to correct them all. might take a while

@seunlanlege
Copy link
Author

just ran testcrate/ui/update-all-references.sh and it updated all the snapshots. 🤝

@seunlanlege
Copy link
Author

@withoutboats yay 🎊 this looks ready to be merged 🙌

@withoutboats withoutboats merged commit feb0510 into alexcrichton:0-1 Apr 11, 2018
@withoutboats
Copy link
Collaborator

@seunlanlege great, thanks!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants