Show multiplayer session ID to the user in multiplayer popups. #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the 5 digit code in the URL of the web version, used by the websocket server to decide which players to connect a player with. The wxWidgets implementation doesn't need this, since its server is only for a single session. I think I implemented a normal socket client for the native Android version too.
…roid implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, if someone is waiting for their friend to join and can't understand why it isn't working, hopefully it will be a bit more intuitive that the session IDs must match. People might not think to look at the URL at all, but maybe they'll notice the session ID now that it is at the top of the multiplayer popups.