Dt search #25
Dt search #25
Conversation
There was a problem hiding this comment.
Looking good, but the requires in RecipesController and poros/recipe.rb go against Rails' 'convention over configuration' philosophy. There are a couple ways to structure these POROs in a way that Rails will know about them without having a require -- the simplest being relocate the POROs folder to app/poros and then removing the require(_relative)s RecipesController and Recipe. Another alternative would be to rename the poros folder to spoonacular, and then wrapping the PORO classes inside in a Spoonacular module so you can call Spoonacular::Recipe from the RecipesController without the require. Wrapping them in a module also puts recipe_ingredients/instructions/nutrition into the same scope so the require_relatives would become unnecessary. Brownfield came with an example of the latter structure with its models/you_tube POROs folder/module.
Sorry for the wall of text! I pushed up a branch agl_dt_search with a proof of concept if you are interested in taking a gander.
| Recipe.new(recipe_json) | ||
| end | ||
| if @recipes.empty? | ||
| flash[:error] = "Sorry, we couldn't find any recipes matching your |
| @@ -0,0 +1,24 @@ | |||
| class RecipesController < ApplicationController | |||
| def index | |||
| recipes = SpoonacularService.new(search_params).parse_recipes | |||
There was a problem hiding this comment.
Probably a good place for a refactor later down the line.
| @@ -0,0 +1,33 @@ | |||
| class Recipe | |||
| attr_reader :id, | |||
There was a problem hiding this comment.
Are we using this ID for something later? Do we need to expose it? - Nevermind
Oh... yeah, for the ID in the recipe show
| type: @params['type'], | ||
| minCalories: 0, minCholesterol: 0, | ||
| minFat: 0, minProtein: 0, minCarbs: 0, minSugar: 0, minSodium: 0, | ||
| number: 10, sort: 'random' }.compact |
There was a problem hiding this comment.
getting rid of nils, nice!
| <%= text_field_tag :ingredients, nil, placeholder: "Enter your ingredients:" %><br> | ||
| <h2>DIET</h2> | ||
| <%= check_box_tag 'diet[]', 'vegetarian' %> | ||
| <%= label_tag :vegetarian %><br> |
There was a problem hiding this comment.
Just a heads up... I think we'll have pretty much all of these in a container of some sort and won't need the
tags.... I think...
Completed:
Refactor:
@id, @title, @image, @ingredients, @instructions, @time, @nutrition