Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker-compose image tax syntax #4016

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

stchris
Copy link
Contributor

@stchris stchris commented Nov 26, 2024

This should fix #4001 , which probably broke during a merge.

Copy link
Contributor

@tillprochaska tillprochaska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the same issue was introduced in this file: https://github.com/alephdata/aleph/blob/main/contrib/keycloak/docker-compose.dev-keycloak.yml

And a similar issue in this file (repetition in the row for global.image.tag):
https://github.com/alephdata/aleph/blob/develop/helm/charts/aleph/README.md?plain=1

Could you fix these, too, before merging? Apart from that, this looks good, thanks for taking care of it.

@tillprochaska
Copy link
Contributor

And could you make sure to cherry-pick these changes onto main afterwards?

@stchris
Copy link
Contributor Author

stchris commented Nov 26, 2024

Looks like the same issue was introduced in this file: https://github.com/alephdata/aleph/blob/main/contrib/keycloak/docker-compose.dev-keycloak.yml

I'm confused, but I thought this PR fixes exactly that file?

And a similar issue in this file (repetition in the row for global.image.tag): https://github.com/alephdata/aleph/blob/develop/helm/charts/aleph/README.md?plain=1

Will do! Thanks for catching that!

And could you make sure to cherry-pick these changes onto main afterwards?

Absolutely, that was the plan (and how I noticed this).

@stchris stchris force-pushed the chore/fix-docker-compose branch from 4b8f554 to 716a67e Compare November 26, 2024 09:52
@tillprochaska
Copy link
Contributor

I'm confused, but I thought this PR fixes exactly that file?

Sorry, you’re right! I somehow got confused in the diff view :/

@stchris stchris merged commit 32ad1b9 into develop Nov 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: invalid reference format in docker-compose.yml
2 participants