Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I'm doing several things, and the primary one - I'm fixing the way how it is included in ActiveRecord. Currently, it has been missing Arel, which has
to_sql
methods too. Niceql would be a perfect addition there.I have removed 2 and added 2 other classes to make the inclusion more comprehensive and consistent.
ActiveRecord:Base
- it doesn't have to_sql methodActiveRecord::Associations::CollectionProxy
because it uses the same implementation asRelation
:Arel::TreeManager
: https://github.com/rails/rails/blob/main/activerecord/lib/arel/tree_manager.rb#L49Arel::Nodes::Node
: https://github.com/rails/rails/blob/main/activerecord/lib/arel/nodes/node.rb#L39Also, I think that
extract_err_caret_line
is meant to be a private method.