Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utilities for working with URIs to HttpSuite #230

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Add utilities for working with URIs to HttpSuite #230

merged 2 commits into from
Jun 7, 2022

Conversation

alejandrohdezma
Copy link
Owner

@alejandrohdezma alejandrohdezma commented Jun 7, 2022 •
edited
Loading

Simplifies working with Uri on HttpSuite suites:

// Before
override def baseUri() = Uri.unsafeFromString(s"http://localhost:${container().getServicePort("app", 8080)}")

// After
override def baseUri() = localhost.withPort(container().getServicePort("app", 8080))

@github-actions github-actions bot added 🚀 feature New feature or improvement ⚖️ XS Size of PR between 10 and 50 lines labels Jun 7, 2022
@alejandrohdezma alejandrohdezma requested a review from gutiory June 7, 2022 14:31
@alejandrohdezma alejandrohdezma merged commit c6ee783 into main Jun 7, 2022
@alejandrohdezma alejandrohdezma deleted the feature/add-uri-utilities branch June 7, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gutiory gutiory Awaiting requested review from gutiory

Assignees
No one assigned
Labels
⚖️ XS Size of PR between 10 and 50 lines 🚀 feature New feature or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alejandrohdezma