Add ABAP lexer #281
Merged
Add ABAP lexer #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can check out this tweet if you need anything more or look at the comment I wrote on the issue. But definetly look much better now, but I would also change colours :) |
|
Thanks! |
|
@Stegosawr colours depend on the selected colour scheme. |
|
Thanks alot for the quick enhancement :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ABAP lexer to Chroma. I based it on the lexer that's already in Pygments.
To validate I used code from the issue and a piece from this GitHub code. There were no error classes and seemingly everything seems to match well:
(Of course the CSS colours I used could be prettier.)
Feedback or suggestions are of course more than welcome.
Closes #278