-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Autoload Last File Option #183
Conversation
Regarding:
My initial thought on the easiest and 'safe' approach to not disrupt user flows is to always load the stored watchlist from the config first, then load the last saved file. If they don't match 1:1 a warning is shown giving the user a chance to save the scratch, or alternatively load it instead of the file. This works for single users working on a DMW list. However, once you introduce a shared DMW in a git repo with a team working on it, the flow can get annoying.
So long as the user 'knows' they had nothing, they could simplify tell the popup to discard and load from the file. |
I've mulled it over a bit. I think for now, I want to disable this feature by default, and that way I can ignore doing the compare with the scratch/temp watchlist. As users decide which they prefer, they can safely migrate to the feature being enabled if that works best for them. This also solves the multi user situation since the scratch would be ignored completely, so user B would not receive the false pop up in the above scenario. |
e28a054
to
d3aca29
Compare
d3aca29
to
00578a6
Compare
This feature autoloads the last .DMW you have previously loaded. This is useful if working on a .DMW file you regularly commit to a shared repository. - Enabling the feature will stop saving to the 'temporary' watchlist space. - Disabling the feature will clear your current watchlist (giving you an opportunity to save it if you have not), and then load the old 'temporary' watchlist. - Closing DME will now prompt you to save if this mode is on and you have not saved - Clearing the watchlist now also drops the file reference
d0bdf02
to
3fc7990
Compare
Implements #121
This feature autoloads the last .DMW you have previously loaded.
This is useful if working on a .DMW file you regularly commit to a shared repository.
Changes
m_watchListFile
public - necessary to get file location, and to be used later in Feature: Display 'active' opened .DMW file #182TODOs (All Done)
[WONTDO] // TODO: Potentially restoreWatchModel first, then openWatchFile in autoload scenario. If they don't match, warn/prompt unsaved changes in model.[x] Do we want auto-load by default - No, for now we will default to off
[x] Potentially a way to switch between 'scratch' (the stored watchmodel in the config) and files on the fly? - The config watchlist will not be saved, that way you can turn off the feature to switch between them
[x] Lint
[x] Ensure when a user toggles the feature on/off the stored watchmodel is not overwritten. Warn the user if unsaved changes, and then reload the watchlist, or prompt to save it
[x] Don't save the config/scratch stored watchlist if this feature is enabled - prevents data loss