Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Dolphin hook status to status bar. #156

Merged
merged 1 commit into from
May 28, 2024

Conversation

cristian64
Copy link
Collaborator

It reduces the clutter in the GUI by saving several lines of vertical space in the main window.

Bonus: A state icon is now included for each of the four possible states, as well as the game ID of the emulated game when present.

DME - Unhooked
DME - Dolphin not detected
DME - No game running
DME - Hooked

It reduces the clutter in the GUI by saving several lines of vertical
space in the main window.

Bonus: A state icon is now included for each of the four possible
states, as well as the game ID of the emulated game when present.

![DME - Unhooked](https://github.com/aldelaro5/dolphin-memory-engine/assets/1853278/506a223f-c90d-4d44-9a9b-57115ed56bd7)
![DME - Dolphin not detected](https://github.com/aldelaro5/dolphin-memory-engine/assets/1853278/4b9fd1ea-ea65-4d6b-9c56-3d37ec4702a1)
![DME - No game running](https://github.com/aldelaro5/dolphin-memory-engine/assets/1853278/91c8103e-257c-40c7-897a-157fe20da4df)
![DME - Hooked](https://github.com/aldelaro5/dolphin-memory-engine/assets/1853278/2e39c4e9-aee0-48b1-9f13-e25a294d8950)
@dreamsyntax
Copy link
Collaborator

dreamsyntax commented May 27, 2024

Hmm... I know its traditional to have the status bar on the bottom, but would you consider having an option for the top? I may add it as an option under View.

I'm thinking aligned with the scanner perhaps if the scanner Search Range is visible - and on the bottom if its not.

Functionality tested and the spacing is nice, but there's just something with muscle memory with me wanting the bar up top like this mockup:

image

Copy link
Collaborator

@dreamsyntax dreamsyntax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as I think its just a me thing, and I can add the above later.

@cristian64
Copy link
Collaborator Author

In the mockup, the status bar is in a place that is occupied by a label [that is only visible after the first search]: the one that shows number of matches.

I too noticed muscle memory was a thing, but to be fair it went away after just a few minutes.

One option we can consider (I'd love to see mockups) is moving it to the very right in the top menu's bar (at the very right of the Help menu). We might need to reverse the layout direction so that the icon stays at the corner.

@dreamsyntax dreamsyntax merged commit fd7827f into aldelaro5:master May 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants