Use splitter's section size to determine whether scanner pane is visible. #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble. This was a regression in e8ea2b3, where the visibility predicate was changed to something more readable. As it turned out, the visibility of the widget does not indicate whether it is visible: the splitter may be collapsed. The predicate has now been reverted to what it was previously. Test plan: - Launch DME. - Collapse the scanner pane. - Exit DME. - Launch DME. Without this change, the **View > Scanner** would be checked, even though the pane is collapsed.
dreamsyntax
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a regression in e8ea2b3, where the visibility predicate was changed to something more readable. As it turned out, the visibility of the widget does not indicate whether it is visible: the splitter may be collapsed.
The predicate has now been reverted to what it was previously.
Test plan:
Without this change, the View > Scanner would be checked, even though the pane is collapsed.