Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework of the **About** dialog. #111

Merged
merged 1 commit into from
Mar 9, 2024

Conversation

cristian64
Copy link
Collaborator

@cristian64 cristian64 commented Mar 8, 2024

Application logo, as well as links to the source code, license file, contributors page, and releases page, have been included:

Dolphin Memory Engine - About Dialog

Copy link
Collaborator

@dreamsyntax dreamsyntax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer linking to the project page instead of /releases, but im fine either way.

@aldelaro5
Copy link
Owner

I'd prefer linking to the project page instead of /releases, but im fine either way.

I am fine either way too, but as a suggestion: you could have a link label for "releases" and another for "source code".

I say this because it is very surprising how users don't know how to access the release page from the home page (even with a link at the start of the readme).

@cristian64
Copy link
Collaborator Author

I'd prefer linking to the project page instead of /releases, but im fine either way.

How about both? What would the label be? And in which position?

@cristian64
Copy link
Collaborator Author

I'd prefer linking to the project page instead of /releases, but im fine either way.

I am fine either way too, but as a suggestion: you could have a link label for "releases" and another for "source code".

I say this because it is very surprising how users don't know how to access the release page from the home page (even with a link at the start of the readme).

This is perhaps why I went for "Updates" instead of "Releases", because "Releases" feels a bit too technical.

@cristian64
Copy link
Collaborator Author

Some options:

  1. Project Page | License | Contributors | Updates
  2. Project Site | License | Contributors | Software Updates
  3. License | Contributors | Software Updates
  4. License | Contributors | Releases
  5. Source Code | License | Contributors | Updates

Thoughts? I don't really have a strong opinion. The application is quite niche: I'm sure anybody that uses it is technical enough to find all the info, even if we don't include it here.

@dreamsyntax
Copy link
Collaborator

Some options:

1. Project Page | License | Contributors | Updates

2. Project Site | License | Contributors | Software Updates

3. License | Contributors | Software Updates

4. License | Contributors | Releases

5. Source Code | License | Contributors | Updates

Thoughts? I don't really have a strong opinion. The application is quite niche: I'm sure anybody that uses it is technical enough to find all the info, even if we don't include it here.

I like
1 or 5

Open to either, your choice.

@cristian64 cristian64 force-pushed the about_dialog_revision branch from 3453f11 to 6b84b13 Compare March 8, 2024 23:29
Application logo, as well as links to the source code, license file,
contributors page, and releases page, have been included:

![Dolphin Memory Engine - About Dialog](https://github.com/aldelaro5/dolphin-memory-engine/assets/1853278/9ed018a6-ebf7-4061-8d6b-eba6b9327a27)
@cristian64 cristian64 force-pushed the about_dialog_revision branch from 6b84b13 to 60ce18e Compare March 8, 2024 23:29
@cristian64
Copy link
Collaborator Author

I've gone for Option 5. (Happy to make further tweaks if more suggestions are made.)

@dreamsyntax dreamsyntax merged commit 541258a into aldelaro5:master Mar 9, 2024
4 checks passed
@cristian64
Copy link
Collaborator Author

cristian64 commented Mar 9, 2024

As I was checking how the dialog looked like on Windows, I noticed the icon is not working:

image

Then I noticed the build is not bundling the SVG plug-in. The external Qt library does not have it either; it appears to be a reduced version. We may have to get a new, more complete version (perhaps Qt 6.5.3).

EDIT: The external library does have it; we are just not bundling it.
EDIT 2: The external library for macOS does not have it.

@cristian64
Copy link
Collaborator Author

cristian64 commented Mar 9, 2024

SVG logo is now rasterized after #112:

image

Now noticing that the copyleft symbol 🄯 (ɔ) is not available on the font family on Windows. I may open a PR for this. (See #113.)


We also don't know how the dialog looks like on macOS. As mentioned in my previous comment, the external Qt library for macOS in the Git submodule does not include the QtSvg component; I guess the SVG logo won't work there until that is addressed.

@campital Is this something you would like to look into? When you uploaded the macOS library, did you leave out the QtSvg module, or was it not compiled by default in macOS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants