Add the --dolphin-process-name command-line option.

[cristian64]

Used to override the name of the Dolphin Emulator process that the DME will search for in the system while trying to hook.

The short version of the option is -d.

The [undocumented] DME_DOLPHIN_PROCESS_NAME environment variable can
be used alternatively.

Fixes #42.

This work also enables the --version and --help command-line arguments.

Bonus: Trailing spaces, as well as \r characters, have been removed.

[cristian64]

The first two three commits are only whitespace changes. (I can move them to a separate PR if it makes things easier.)

The changes for Windows and macOS have been made blindly; unable to test. Let's see if the build succeeds. (It builds.)

EDIT: @dreamsyntax Would you able to test at least on Windows? It'd be interesting to test also with non-ASCII characters, which I'm hoping it will work.

[dreamsyntax]

Would you able to test at least on Windows? It'd be interesting to test also with non-ASCII characters, which I'm hoping it will work.

Tested with process name '攫'

Launching with no arg:

Launching with --dolphin-process-name 攫 or -d 攫:
No luck, does not detect the process.

Launching with --dolphin-process-name 攫.exe or -d 攫.exe:
Attached properly.

Also tested with ShadowSX as name of Dolphin process. The results are the same.

--
Testing with no modification to Dolphin.exe also works as expected.

--
Can we implicitly add .exe to the search type of the user does not specify? Or do you think its standard to require it?

[cristian64]

Would you able to test at least on Windows? It'd be interesting to test also with non-ASCII characters, which I'm hoping it will work.

[...]

-- Can we implicitly add .exe to the search type of the user does not specify? Or do you think its standard to require it?

I think my preference is to be specific, but I'm having a hard time finding a case where the implicit extension could be a problem. So, happy to add it if you haven't changed your mind since your comment.

[dreamsyntax]

Would you able to test at least on Windows? It'd be interesting to test also with non-ASCII characters, which I'm hoping it will work.

[...]
-- Can we implicitly add .exe to the search type of the user does not specify? Or do you think its standard to require it?

I think my preference is to be specific, but I'm having a hard time finding a case where the implicit extension could be a problem. So, happy to add it if you haven't changed your mind since your comment.

I would think
-> check explicit, if not found and on windows assume .exe or something like that

Or just make it clear in the help/readme that windows must include the extension.
I'm fine with that too.

[cristian64]

Would you able to test at least on Windows? It'd be interesting to test also with non-ASCII characters, which I'm hoping it will work.

[...]
-- Can we implicitly add .exe to the search type of the user does not specify? Or do you think its standard to require it?

I think my preference is to be specific, but I'm having a hard time finding a case where the implicit extension could be a problem. So, happy to add it if you haven't changed your mind since your comment.

I would think -> check explicit, if not found and on windows assume .exe or something like that

Or just make it clear in the help/readme that windows must include the extension. I'm fine with that too.

The option's help description does say the file extension must be given, but the Windows ecosystem is known for not minding.

[dreamsyntax]

Would you able to test at least on Windows? It'd be interesting to test also with non-ASCII characters, which I'm hoping it will work.

[...]
-- Can we implicitly add .exe to the search type of the user does not specify? Or do you think its standard to require it?

I think my preference is to be specific, but I'm having a hard time finding a case where the implicit extension could be a problem. So, happy to add it if you haven't changed your mind since your comment.

I would think -> check explicit, if not found and on windows assume .exe or something like that
Or just make it clear in the help/readme that windows must include the extension. I'm fine with that too.

The option's help description does say the file extension must be given, but the Windows ecosystem is known for not minding.

Your call. I'm fine either way, merge when you think its good to go.
If you dont do this:
#105 (comment)
I can just add it before release.

[cristian64]

I've made the tweak so that, on Windows, the .exe file extension can be omitted.

[dreamsyntax]

Tested with
-d test
and
-d test.exe

Both work as expected.