Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Float search is influenced by Decimal / Hexidecimal / Octal / Binary radio button #191

Closed
KingJigglypuff opened this issue Feb 26, 2025 · 4 comments · Fixed by #192
Closed
Assignees
Labels

Comments

@KingJigglypuff
Copy link

I recently switched to the latest Dolphin Memory Engine after using an older version for an unspecified period of time, and one thing I really don't like is how the scanner only uses hex when scanning for floats. For instance, if I wanted to search for 2.5, I'd have to convert it into hex (2.5 in hex is 40200000) and search for that. Because if you use a decimal value when scanning, it'll think you're using hexadecimal integers (using 2.5 as an example again, putting in 2.5 will make it think you're looking for 2). This forces you to constantly convert your floats into hex whenever you want to search for a float, which I find rather unintuitive.

I don't know whether or not it's a regression, or if it's intentional. Though regardless, I'd like to suggest/request the same toggle that's used when searching for bytes also be integrated when scanning for floats (the one that lets you choose between hexadecimal, decimal, octal, or binary). Because I'm sure there's some use cases for searching floats with hexadecimal values.

@dreamsyntax
Copy link
Collaborator

dreamsyntax commented Feb 26, 2025

using 2.5 as an example again, putting in 2.5 will make it think you're looking for 2

Can you provide your configuration file?
This is not the behavior I see. Float searching works just fine:

Image

If you meant the watchlist, you can view it in any format you desire:
Image

use cases for searching floats with hexadecimal values.

You would just use "Array of bytes" search type in that case.

@dreamsyntax
Copy link
Collaborator

Update, no need to provide a config.
There is a bug somewhere.

If you search for a byte with the radio button set to Hexadecimal and then switch back to float, it is affecting the search feature.

@dreamsyntax dreamsyntax changed the title Scanning Fix/QoL: Add Decimal Toggle When Scanning for Floats Bug: Float search is influenced by Decimal / Hexidecimal / Octal / Binary radio button Feb 26, 2025
@dreamsyntax dreamsyntax self-assigned this Feb 26, 2025
dreamsyntax added a commit that referenced this issue Feb 26, 2025
Resolves #191
Previously set value while viewing binary/word etc would influence
scan. I verified unaligned option also works, though makes
scanning take longer.
dreamsyntax added a commit that referenced this issue Feb 26, 2025
Resolves #191
Previously set value while viewing binary/word etc would influence
scan. I verified unaligned option also works, though makes
scanning take longer.
@dreamsyntax
Copy link
Collaborator

Opting to just enable these views for float and double. I see no reason to restrict them.
Thanks for reporting this.

@dreamsyntax
Copy link
Collaborator

This is now released in v1.2.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants