-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Win build #4
Win build #4
Conversation
kkirstein
commented
Jun 15, 2015
- add symbol definitions for Windows build
- fix function signature for Windows in remutex package
- add build instruction for Windows to Readme
@aldanor I just created a pull request with the Windows-enabled version. I added some build instructions to the Readme. I also had a short look at appveyor, looks like a good option, although I have no experience with CI from the cloud. |
Thanks a lot for the PR! I won't have time to look at it in detail till weekend but it looks good from the first glance -- although I have no way of testing it actually works on Windows right now other than taking your word on it -- would be really great to try and set up a CI build for it. I have no experience with Appveyor but it looks reasonable. Maybe you could take a look at PyTables build? See PR here: PyTables/PyTables#426 As for MSVC interoperability, it looks like there's some very recent ongoing work going upstream, see here for more details:
Ideally, we'd want to support both mingw and msvc builds, if possible at all. |
@aldanor Thanks, for pointing to the discussions on rust-lang! |
@kkirstein You're welcome! By the way, I've noticed that many rust-lang repos were set up for appveyor builds about a week ago -- see, for instance, rust-lang/regex@1be2fee -- maybe that could be a good starting point. Good call with |
add #[inline] attributes for simple winapi wrappers as suggested by @retep998 retep998@c121ce2
Closed in favor of #7. |
Rename hdf5* -> hdf5-metno*