Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 2.3.2 #390

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Conversation

xiki-tempula
Copy link
Collaborator

@xiki-tempula xiki-tempula commented Aug 24, 2024

remove python 3.9 support

@xiki-tempula xiki-tempula linked an issue Aug 24, 2024 that may be closed by this pull request
5 tasks
Copy link

codecov bot commented Aug 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (911ce53) to head (0b9de02).
Report is 27 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
- Coverage   98.83%   98.73%   -0.11%     
==========================================
  Files          28       28              
  Lines        1895     1895              
  Branches      407      407              
==========================================
- Hits         1873     1871       -2     
  Misses          2        2              
- Partials       20       22       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@xiki-tempula
Copy link
Collaborator Author

Looks like we cannot have any badge in the readme for security reasons. pypa/readme_renderer#304 (comment)

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if badges need removing.

setup.py Show resolved Hide resolved
@xiki-tempula
Copy link
Collaborator Author

xiki-tempula commented Aug 24, 2024

here is the failed pipeline https://github.com/alchemistry/alchemlyb/actions/runs/10537263963/job/29198456637
I can only get it to work by removing the badge

@orbeckst
Copy link
Member

Can you try replacing .svg in the README badges with .png and not removing them from the PyPi README? This may work without any intermediate conversion magic under the hood and keep our scripts clearer.

@xiki-tempula
Copy link
Collaborator Author

xiki-tempula commented Aug 25, 2024

@orbeckst
Copy link
Member

Ah well, thanks for trying it out — I had just manually replaced a svg -> png for I think zenodo and that had worked.

SVG
DOI

[![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.12692737.svg)](https://doi.org/10.5281/zenodo.12692737)

PNG
DOI

[![DOI](https://zenodo.org/badge/DOI/10.5281/zenodo.12692737.png)](https://doi.org/10.5281/zenodo.12692737)

But for codecov it does not work, as you say:
https://codecov.io/gh/alchemistry/alchemlyb/branch/master/graph/badge.png gives indeed


Badge Handler

GET /gh/alchemistry/alchemlyb/branch/master/graph/badge.png

HTTP 404 Not Found
Allow: GET, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "detail": "File extension should be one of [ svg || txt ]"
}

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with your original solution. Just add a comment, please.

README.md Outdated
@@ -1,6 +1,6 @@
# alchemlyb: the simple alchemistry library

[![Zenodo DOI](https://zenodo.org/badge/68669096.svg)](https://zenodo.org/badge/latestdoi/68669096) [![Documentation](https://readthedocs.org/projects/alchemlyb/badge/?version=latest)](http://alchemlyb.readthedocs.io/en/latest/) [![Build Status](https://github.com/alchemistry/alchemlyb/actions/workflows/ci.yaml/badge.svg?branch=master)](https://github.com/alchemistry/alchemlyb/actions/workflows/ci.yaml) [![Code coverage](https://codecov.io/gh/alchemistry/alchemlyb/branch/master/graph/badge.svg)](https://codecov.io/gh/alchemistry/alchemlyb) [![anaconda package](https://anaconda.org/conda-forge/alchemlyb/badges/version.svg)](https://anaconda.org/conda-forge/alchemlyb)
[![Zenodo DOI](https://zenodo.org/badge/68669096.png)](https://zenodo.org/badge/latestdoi/68669096) [![Documentation](https://readthedocs.org/projects/alchemlyb/badge/?version=latest)](http://alchemlyb.readthedocs.io/en/latest/) [![Build Status](https://github.com/alchemistry/alchemlyb/actions/workflows/ci.yaml/badge.png?branch=master)](https://github.com/alchemistry/alchemlyb/actions/workflows/ci.yaml) [![Code coverage](https://codecov.io/gh/alchemistry/alchemlyb/branch/master/graph/badge.png)](https://codecov.io/gh/alchemistry/alchemlyb) [![anaconda package](https://anaconda.org/conda-forge/alchemlyb/badges/version.png)](https://anaconda.org/conda-forge/alchemlyb)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for trying it out — didn't work

setup.py Show resolved Hide resolved
@xiki-tempula xiki-tempula force-pushed the 389-release-232-for-joss-publication branch from 9d3e761 to 0b9de02 Compare August 25, 2024 09:43
@xiki-tempula xiki-tempula requested a review from orbeckst August 25, 2024 09:43
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's remove the badges.

I'll let you squash-merge as part of the release.

@xiki-tempula xiki-tempula merged commit 8d3dabc into master Aug 26, 2024
7 of 8 checks passed
@xiki-tempula xiki-tempula deleted the 389-release-232-for-joss-publication branch August 26, 2024 07:20
@xiki-tempula
Copy link
Collaborator Author

@orbeckst Do I need to do something for zenodo or it is done automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release 2.3.2 for JOSS publication
2 participants