-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for 2.3.2 #390
Prepare for 2.3.2 #390
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #390 +/- ##
==========================================
- Coverage 98.83% 98.73% -0.11%
==========================================
Files 28 28
Lines 1895 1895
Branches 407 407
==========================================
- Hits 1873 1871 -2
Misses 2 2
- Partials 20 22 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Looks like we cannot have any badge in the readme for security reasons. pypa/readme_renderer#304 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if badges need removing.
here is the failed pipeline https://github.com/alchemistry/alchemlyb/actions/runs/10537263963/job/29198456637 |
Can you try replacing |
@orbeckst I don't think any of the badge support png format https://github.com/alchemistry/alchemlyb/tree/389-release-232-for-joss-publication |
Ah well, thanks for trying it out — I had just manually replaced a svg -> png for I think zenodo and that had worked.
But for codecov it does not work, as you say:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with your original solution. Just add a comment, please.
README.md
Outdated
@@ -1,6 +1,6 @@ | |||
# alchemlyb: the simple alchemistry library | |||
|
|||
[![Zenodo DOI](https://zenodo.org/badge/68669096.svg)](https://zenodo.org/badge/latestdoi/68669096) [![Documentation](https://readthedocs.org/projects/alchemlyb/badge/?version=latest)](http://alchemlyb.readthedocs.io/en/latest/) [![Build Status](https://github.com/alchemistry/alchemlyb/actions/workflows/ci.yaml/badge.svg?branch=master)](https://github.com/alchemistry/alchemlyb/actions/workflows/ci.yaml) [![Code coverage](https://codecov.io/gh/alchemistry/alchemlyb/branch/master/graph/badge.svg)](https://codecov.io/gh/alchemistry/alchemlyb) [![anaconda package](https://anaconda.org/conda-forge/alchemlyb/badges/version.svg)](https://anaconda.org/conda-forge/alchemlyb) | |||
[![Zenodo DOI](https://zenodo.org/badge/68669096.png)](https://zenodo.org/badge/latestdoi/68669096) [![Documentation](https://readthedocs.org/projects/alchemlyb/badge/?version=latest)](http://alchemlyb.readthedocs.io/en/latest/) [![Build Status](https://github.com/alchemistry/alchemlyb/actions/workflows/ci.yaml/badge.png?branch=master)](https://github.com/alchemistry/alchemlyb/actions/workflows/ci.yaml) [![Code coverage](https://codecov.io/gh/alchemistry/alchemlyb/branch/master/graph/badge.png)](https://codecov.io/gh/alchemistry/alchemlyb) [![anaconda package](https://anaconda.org/conda-forge/alchemlyb/badges/version.png)](https://anaconda.org/conda-forge/alchemlyb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for trying it out — didn't work
9d3e761
to
0b9de02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's remove the badges.
I'll let you squash-merge as part of the release.
@orbeckst Do I need to do something for zenodo or it is done automatically? |
remove python 3.9 support