-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slicing will no longer drop the NaN rows #275
Conversation
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
- Coverage 98.69% 98.69% -0.01%
==========================================
Files 26 26
Lines 1762 1761 -1
Branches 379 379
==========================================
- Hits 1739 1738 -1
Misses 3 3
Partials 20 20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ded5d1b
to
0b1a46b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not dropping NaN makes sense. We didn't even state that we were doing it so this is a fix to remove undocumented and potentially erroneous behavior.
Thank you @xiki-tempula and @orbeckst ! |
Fix #274
The Pre-processing function slicing will not drop NaN rows.