Fix detection of empty keys in arrays and objects #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both $criteria and $newobj may be objects (see https://github.com/mongodb/mongo-php-driver-legacy/blob/16c9a1e49d3db59aaa84c6efd5f6fde84b7a3a85/collection.c#L1600..L1605), even though the docs state array for both types.
The empty key check needs to recurse into nested arrays and objects. This fixes an error where using a document with an empty key in an atomic update operator wasn't properly detected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request supersedes #196 and improves the checks used. The
MongoCollection::checkKeysmethod already checks for empty keys, but didn't recursively check nested arrays and objects, which caused the original error.While fixing this, I realized that the code to check whether the given value is an array or object in
MongoCollection::insertwas incomplete, so that was improved. Last but not least,MongoCollection::updatemay also take an array or object according to the driver code (which conflicts the official documentation), so the method signature was updated accordingly. As this is considered a bug fix this does not constitute a BC break; the original BC break was me adding the wrong typehint in the first place.