Improve explain functionality #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
reviewed
Aug 30, 2017
| @@ -276,7 +276,7 @@ protected function getOptions($optionNames = null) | |||
| $converter = 'convert' . ucfirst($option); | |||
| $value = method_exists($this, $converter) ? $this->$converter() : $this->$option; | |||
|
|
|||
| if ($value === null) { | |||
| if ($value === null || ($option === 'projection' && $value === [])) { | |||
There was a problem hiding this comment.
Line 277 checks to see if a convert<Option> method exists. This special case should be handled in a convertProjection method.
added 2 commits
August 30, 2017 12:11
…f empty projection array based on CR comment
…The important assertion is the nReturned anyway
|
Thanks! Just a quick heads up, I'm heading out for a vacation, so I won't be able to merge these until I'm back in a couple of weeks. Sorry for the delay! |
|
No worries! |
|
Thanks @robwil! |
|
Thanks for merging all of these @alcaeus . With these 4 fixes in place, all of our unit tests & integration tests passed on a very old legacy PHP application relying on the old mongo driver. Couldn't have done it so quickly without this adapter, so thanks for all your work on this! |
|
Thank you for those kind words and your contributions, they are very much appreciated! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the issues outlined in issue #188