Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not write reserved fields in DBFField.write() ? #104

Closed
jmor7690 opened this issue Jan 29, 2022 · 0 comments
Closed

Why not write reserved fields in DBFField.write() ? #104

jmor7690 opened this issue Jan 29, 2022 · 0 comments
Assignees

Comments

@jmor7690
Copy link

Currently, DBFField writes zero values for the reserved fields (line 283 and below). Why not write the approppriate fields instead?

Proposed change:

// data type
out.writeByte(this.type.getCode()); /* 11 */
out.writeInt(DBFUtils.littleEndian(this.reserv1)); //0x00); /* 12-15 */
out.writeByte(this.length); /* 16 */
out.writeByte(this.decimalCount); /* 17 */
out.writeShort(DBFUtils.littleEndian(this.reserv2)); //(short) 0x00); /* 18-19 */
out.writeByte(this.workAreaId); //(byte) 0x00); /* 20 */
out.writeShort(DBFUtils.littleEndian(this.reserv3)); //(short) 0x00); /* 21-22 */
out.writeByte(this.setFieldsFlag); //(byte) 0x00); /* 23 */
out.write(this.reserv4); //new byte[7]); /* 24-30 */
out.writeByte(this.indexFieldFlag); //(byte) 0x00); /* 31 */
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants