Skip to content

Commit

Permalink
Run tests even when formatting check fails
Browse files Browse the repository at this point in the history
  • Loading branch information
adrhill committed May 2, 2022
1 parent 08569d4 commit a1ea049
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ on:
- pull_request

jobs:
linting:
# Run linting outside of matrix
formatting:
# Run formatting checks outside of matrix
name: Formatting
runs-on: ubuntu-latest
steps:
# Check-out repo and set-up python
Expand All @@ -25,12 +26,14 @@ jobs:
- name: Format check with isort
run: isort --check .
test:
needs: linting
name: Python ${{ matrix.python-version }} - ${{ matrix.os }} - ${{ github.event_name }}
strategy:
fail-fast: true
matrix:
os: [ "ubuntu-latest", "windows-latest" ]
python-version: [ "3.7", ]
os:
- ubuntu-latest
python-version:
- '3.7'
defaults:
run:
shell: bash
Expand Down

0 comments on commit a1ea049

Please sign in to comment.