Allow support for overriding the default PyPI index url #26
+72
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanhamlett
reviewed
Dec 20, 2019
pur/__init__.py
Outdated
| @@ -68,6 +68,8 @@ | |||
| help='Prevents updating nested requirements files.') | |||
| @click.option('-s', '--skip', type=click.STRING, help='Comma separated list ' + | |||
| 'of packages to skip updating.') | |||
| @click.option('--index-url', type=click.STRING, help='Comma separated list ' + | |||
There was a problem hiding this comment.
Let's allow --index-url to be passed multiple times with each argument added to a list. Then we can have urls that include commas.
alanhamlett
reviewed
Dec 20, 2019
pur/__init__.py
Outdated
| @@ -311,7 +318,7 @@ def patched_parse_requirements(*args, **kwargs): | |||
| req_file.parse_requirements = patched_parse_requirements | |||
|
|
|||
|
|
|||
| def _get_requirements_and_latest(filename, force=False, minor=[], patch=[], | |||
| def _get_requirements_and_latest(filename, index_url, force=False, minor=[], patch=[], | |||
There was a problem hiding this comment.
This should be optional, like index_urls=[].
alanhamlett
reviewed
Dec 20, 2019
pur/__init__.py
Outdated
| @@ -330,7 +337,7 @@ def _get_requirements_and_latest(filename, force=False, minor=[], patch=[], | |||
| """ | |||
| session = PipSession() | |||
| finder = PackageFinder( | |||
| session=session, find_links=[], index_urls=[PyPI.simple_url]) | |||
| session=session, find_links=[], index_urls=index_url) | |||
There was a problem hiding this comment.
Need to use PyPI.simple_url when index_urls list is empty.
alanhamlett
reviewed
Dec 20, 2019
pur/__init__.py
Outdated
| @@ -201,7 +207,7 @@ def _internal_update_requirements(obuffer, updates, input_file=None, | |||
| try: | |||
| requirements = _get_requirements_and_latest(input_file, force=force, | |||
| minor=minor, patch=patch, | |||
| pre=pre) | |||
| pre=pre, index_url=index_url) | |||
alanhamlett
requested changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow support for overriding the default PyPI index URL to use URLs pointed at a mirror.
Why
Corporate environments often require developers to use a repository mirror and the mirror is not always explicitly defined in the
requirements.txtfile.Example use case:
Issue:
#25