-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order allocation, approval, finance and cost-recovery rows desc by date #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the above clarification about the comment, which is really minor thing, the update looks good to me.
Note I had to add an exception for this vulnerability. It is level critical but I believe it only applies if you are accepting templates as strings from users. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
62cba90
to
f938077
Compare
e258808
to
7aa21b5
Compare
On branch tests_for_post_usage Changes to be committed: modified: tests/test_routes/test_usage.py
As the title suggest, we explicitly order the rows in the details page tables. This may also affect the CLI output but that's not a bad thing.
Closes #38