Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order allocation, approval, finance and cost-recovery rows desc by date #42

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

Iain-S
Copy link
Contributor

@Iain-S Iain-S commented May 14, 2024

As the title suggest, we explicitly order the rows in the details page tables. This may also affect the CLI output but that's not a bad thing.

Closes #38

@Iain-S Iain-S requested a review from dlpbc May 14, 2024 11:30
Copy link
Contributor

@dlpbc dlpbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the above clarification about the comment, which is really minor thing, the update looks good to me.

@Iain-S Iain-S requested a review from dlpbc May 17, 2024 13:00
@Iain-S
Copy link
Contributor Author

Iain-S commented May 17, 2024

Note I had to add an exception for this vulnerability. It is level critical but I believe it only applies if you are accepting templates as strings from users.

Copy link
Contributor

@dlpbc dlpbc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Iain-S Iain-S force-pushed the issue38-frontend-ordering branch from 62cba90 to f938077 Compare June 20, 2024 13:53
@Iain-S Iain-S force-pushed the issue38-frontend-ordering branch from e258808 to 7aa21b5 Compare June 21, 2024 13:37
@Iain-S Iain-S merged commit cccf4ea into main Jun 21, 2024
5 checks passed
@Iain-S Iain-S deleted the issue38-frontend-ordering branch June 21, 2024 13:40
dlpbc added a commit that referenced this pull request Sep 30, 2024
 On branch tests_for_post_usage
 Changes to be committed:
	modified:   tests/test_routes/test_usage.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Ordering in Cost Recovery Table
2 participants