Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logging during SRE provisioning #2033

Conversation

jemrobinson
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

n/a

⤴️ Summary

Log which workspaces are registered during SRE provisioning

🌂 Related issues

n/a

🔬 Tests

Logging only

@jemrobinson jemrobinson requested a review from a team as a code owner July 22, 2024 11:54
@jemrobinson jemrobinson requested a review from a team July 22, 2024 11:54
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/external/interface
  azure_postgresql_database.py 149, 190, 218
  data_safe_haven/provisioning
  sre_provisioning_manager.py 117
Project Total  

This report was generated by python-coverage-comment-action

@JimMadge JimMadge merged commit f31abb2 into alan-turing-institute:develop Jul 22, 2024
11 checks passed
@jemrobinson jemrobinson deleted the improve-provisioning-logging branch January 30, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants