Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRE deployment fixes #2026

Merged
merged 2 commits into from
Jul 19, 2024
Merged

SRE deployment fixes #2026

merged 2 commits into from
Jul 19, 2024

Conversation

jemrobinson
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

n/a

⤴️ Summary

Fixes for bugs encountered during a recent SRE deployment

🌂 Related issues

n/a

🔬 Tests

Tested on fresh SRE deployment

@jemrobinson jemrobinson requested a review from a team as a code owner July 18, 2024 13:18
@jemrobinson jemrobinson requested review from a team, craddm and JimMadge July 18, 2024 13:18
@github-actions GitHub Actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

JimMadge
JimMadge approved these changes Jul 19, 2024
View reviewed changes
Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jemrobinson jemrobinson merged commit 17e9ffc into alan-turing-institute:develop Jul 19, 2024
11 checks passed
@jemrobinson jemrobinson deleted the sre-deployment-fixes branch January 30, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimMadge JimMadge JimMadge approved these changes

@craddm craddm Awaiting requested review from craddm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jemrobinson @JimMadge