Add location specifiers to network resources

[jemrobinson]

✅ Checklist

• You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
• You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
• Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

n/a

⤴️ Summary

Add location specifiers to virtual networks and NSGs as these will otherwise use the default location (which may not be correct).

🌂 Related issues

Closes #2022

🔬 Tests

Tested on previously-broken SRE deployment

[github-actions]

Coverage report

Click to see where and how coverage changed

File	Statements	Missing	Coverage	Coverage (new stmts)	Lines missing
data_safe_haven/infrastructure/programs/sre
application_gateway.py
Project Total

This report was generated by python-coverage-comment-action

[JimMadge]

LGTM

It seems to be good practice to always specify the location.

Do we not have a location specified in the stack configuration? dev.pulumi.yaml equivalent.
Or, does that not guarantee resources will use that location?

It might be there is future work here to make this more robust.

[jemrobinson]

The pulumi-azure-native has a default location set at initialisation time, which is stored in the state file.

"location": "uksouth",
"subscriptionId": <redacted>,
"tenantId": <redacted>,
"version": "2.50.1"

These are set during install_plugins using stack options. These should be in-sync with what's in the config file. The problem that this PR fixes only happens if you change the "location" parameter in the config. The data in the Pulumi state file doesn't get updated (it seems to be "baked in").

I encountered the problem because I tried to deploy into "ukwest" - found that some resources aren't available there, so ran a teardown and redeploy into "uksouth". This left "ukwest" defined in the state file, which was used whenever "location" wasn't explicitly set on a resource.