-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Azure authentication classes #2002
Refactor Azure authentication classes #2002
Conversation
…eded before making external calls
… new GraphApiCredentialLoader rather than using the token directly
…m/.default scope (note that this only allows a subset of functions).
…rough classmethods
e3b4530
to
d2e11dd
Compare
16be0de
to
bf88e6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a few gaps in the coverage in credentials.py
, graph_api.py
and azure_sdk.py
.
Things like getting credentials from files and exception handling.
a3aa287
to
162c2a9
Compare
162c2a9
to
6cf4be6
Compare
@JimMadge : I think this now tests all the functions under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, could leave for another PR if we open an issue.
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
.🚦 Depends on
n/a
AzureSdk
andGraphApi
DeferredCredential
class which can cache tokens to reduce external API callsfinally
clause of a try statementAzureSdkCredential
provides authentication forAzureSdk
using the Azure CLIGraphApiCredential
provides authentication forGraphApi
using a browser device-codehttp_get
where we were ignoring additional pages for paged responses.confirm
dialogue which was applied for AzureCLI logins but not for Browser logins. If we want this, I can easily add it to both.🌂 Related issues
Closes #2001
Closes #1980
🔬 Tests