Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests with IP check #1992

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Fix tests with IP check #1992

merged 1 commit into from
Jul 8, 2024

Conversation

JimMadge
Copy link
Member

@JimMadge JimMadge commented Jul 8, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

Fixes SRE command tests which fail due to IP address not matching admin IP address in the config. (changes introduced in #1977).

🌂 Related issues

🔬 Tests

@JimMadge JimMadge requested a review from a team as a code owner July 8, 2024 10:47
Copy link

github-actions bot commented Jul 8, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/commands
  sre.py
  data_safe_haven/functions
  __init__.py
  data_safe_haven/infrastructure/components/dynamic
  blob_container_acl.py
  dsh_resource_provider.py
  file_upload.py
Project Total  

This report was generated by python-coverage-comment-action

Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JimMadge JimMadge merged commit dba907c into develop Jul 8, 2024
11 checks passed
@JimMadge JimMadge deleted the test_fix branch July 8, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants