Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change package version specifiers to be lower limits #1964

Conversation

jemrobinson
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

n/a

⤴️ Summary

Change package version specifiers to be lower limits

🌂 Related issues

Closes #1944

🔬 Tests

Test in CI

@jemrobinson jemrobinson requested a review from a team as a code owner June 25, 2024 12:19
@jemrobinson jemrobinson requested a review from a team June 25, 2024 12:19
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think there are advantages either way.
>= is more likely to introduce breaks. On the other hand, it means you are aware of problems and can fix them whereas ~= requires more attention for when packages pass a major/minor version.

@jemrobinson jemrobinson merged commit 02fc633 into alan-turing-institute:develop Jun 25, 2024
11 checks passed
@jemrobinson jemrobinson deleted the 1944-remove-dependency-upper-limits branch January 30, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency upper limits
2 participants