Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of files opened during testing #1951

Merged

Conversation

jemrobinson
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

n/a

⤴️ Summary

Avoid opening a new log file for each test

🌂 Related issues

Closes #1950

🔬 Tests

Tested locally and in CI.

@jemrobinson jemrobinson requested a review from a team as a code owner June 20, 2024 11:03
@jemrobinson jemrobinson requested review from a team, JimMadge and craddm June 20, 2024 11:03
Copy link

github-actions bot commented Jun 20, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven
  directories.py
  data_safe_haven/logging
  logger.py
  plain_file_handler.py
Project Total  

This report was generated by python-coverage-comment-action

@jemrobinson jemrobinson mentioned this pull request Jun 20, 2024
3 tasks
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@JimMadge JimMadge merged commit 5a20232 into alan-turing-institute:develop Jun 20, 2024
11 checks passed
@jemrobinson jemrobinson deleted the 1950-close-file-handles branch January 30, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testing breaks due to too many open files
2 participants