-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more informative error messages to context commands #1916
Add more informative error messages to context commands #1916
Conversation
@craddm Is this ready for review? |
Pretty much - some tests failing as the commands now error when not logged in with Azure CLI. Do we know how to handle that? |
@craddm Shall I pick up this one? |
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good. A couple of questions but nothing serious.
@JimMadge : are you still responsible for this PR? Happy to take it over if you're busy. |
Co-authored-by: James Robinson <james.em.robinson@gmail.com>
Co-authored-by: James Robinson <james.em.robinson@gmail.com>
Co-authored-by: James Robinson <james.em.robinson@gmail.com>
Co-authored-by: James Robinson <james.em.robinson@gmail.com>
Co-authored-by: James Robinson <james.em.robinson@gmail.com>
Co-authored-by: James Robinson <james.em.robinson@gmail.com>
Co-authored-by: James Robinson <james.em.robinson@gmail.com>
Co-authored-by: James Robinson <james.em.robinson@gmail.com>
Co-authored-by: James Robinson <james.em.robinson@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
.🚦 Depends on
N/A
Adds more informative messages when users try to use context functions without first having created a context file.
Catches that user is not logged in when trying to create or teardown context infrastructure.
WIP: Catch that no context infrastructure is deployed
🌂 Related issues
Closes #1897
Closes #1899
🔬 Tests
tested locally