Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate coverage for tests #1907

Merged
merged 1 commit into from
May 20, 2024
Merged

Don't generate coverage for tests #1907

merged 1 commit into from
May 20, 2024

Conversation

JimMadge
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

Don't consider test files when calculating coverage.
This will prevent those files being included in the PR comments like here.

🌂 Related issues

🔬 Tests

@JimMadge JimMadge requested a review from a team as a code owner May 20, 2024 11:03
@github-actions GitHub Actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

jemrobinson
jemrobinson approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does it work?

@craddm
Copy link
Contributor

craddm commented May 20, 2024

LGTM - tested locally and it worked.

@JimMadge JimMadge merged commit b7f2c0c into develop May 20, 2024
11 checks passed
@JimMadge JimMadge deleted the coverage branch May 20, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemrobinson jemrobinson jemrobinson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JimMadge @craddm @jemrobinson