Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused components #1874

Merged

Conversation

jemrobinson
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).

⤴️ Summary

Removes components and functions that are no longer being used

🌂 Related issues

n/a

🔬 Tests

Not tested

@jemrobinson jemrobinson requested a review from a team as a code owner May 9, 2024 16:24
@jemrobinson jemrobinson marked this pull request as draft May 9, 2024 16:40
@jemrobinson jemrobinson marked this pull request as ready for review May 9, 2024 17:53
@jemrobinson jemrobinson force-pushed the remove-unused-components branch 4 times, most recently from 7a6117a to f9ecc56 Compare May 9, 2024 20:51
Copy link

github-actions bot commented May 9, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/external
  __init__.py
  data_safe_haven/external/api
  azure_api.py 107-116
  graph_api.py
  data_safe_haven/functions
  strings.py
  data_safe_haven/infrastructure/components/composite
  __init__.py
  data_safe_haven/infrastructure/components/dynamic
  __init__.py
Project Total  

This report was generated by python-coverage-comment-action

@jemrobinson jemrobinson requested a review from a team May 10, 2024 10:31
Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you use a tool to find these?
It would be a good addition to the lint scripts.

@jemrobinson
Copy link
Member Author

Sort of. I used grep 😁

@jemrobinson jemrobinson merged commit 1dbd9aa into alan-turing-institute:develop May 10, 2024
11 checks passed
@jemrobinson jemrobinson deleted the remove-unused-components branch June 3, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants