-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AzureAD/EntraID functionality #1778
Add AzureAD/EntraID functionality #1778
Conversation
…eb. Also allow AzureADApplication to set up an application secret
…lication permissions
a091222
to
05d192a
Compare
👀 Does this remove the "local" SHM AD servers and the SCE NPS servers? |
We've already dropped the NPS servers in 4.2.0 as part of dropping support for Microsoft Remote Desktop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions and questions.
I really like using dynamic components to keep things "in Pulumi" where we can.
I think I struggled a bit with the Graph API stuff because it feels quite abstract.
Regarding the user management commands, do we want CLI commands for convenience (avoid using a browser) or because it automates some quirks or extra steps DSH requires?
I guess initially because I want to maintain our current setup of adding/removing users and groups using the CLI. We can definitely remove this in future, but I think it should be a conscious decision, not a by-product of another large change. |
Co-authored-by: Jim Madge <jim+github@jmadge.com>
8ac5650
to
f627151
Compare
Co-authored-by: Jim Madge <jim+github@jmadge.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions on tidying things up 👍.
Thanks - I especially liked the clarity on explaining our API (not Microsoft's)! |
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
.'[WIP]'
to the title if needed (if you're not yet ready to merge)../tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>
for Powershell).remove
,register
andunregister
methods to AzureADUserscreate_group
function to no longer requiregidNumber
linux_schema
in AzureADremove_user
function to GraphAPIremove_user_from_group
if the user belongs to the group🌂 Related issues
First step towards #1570
🔬 Tests
Tested on a new deployment