Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated NetworkProfile option for ContainerGroups #1734

Conversation

jemrobinson
Copy link
Member

@jemrobinson jemrobinson commented Feb 6, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).
  • You have formatted your code using appropriate automated tools (for example ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory> for Powershell).

⤴️ Summary

  • Update to new ACMEClient syntax
  • Add missing priorities to ApplicationGateway routing rules
  • Replace ContainerGroup NetworkProfiles with subnet IDs.

🌂 Related issues

Closes #1717

🔬 Tests

Tested on new SRE deployment

@jemrobinson jemrobinson requested a review from a team February 6, 2024 12:01
@jemrobinson jemrobinson force-pushed the 1717-fix-containergroup-networkprofiles branch from 212540f to 076dacc Compare February 6, 2024 16:49
@jemrobinson jemrobinson force-pushed the 1717-fix-containergroup-networkprofiles branch from 076dacc to d2d6f0b Compare February 6, 2024 16:52
@jemrobinson jemrobinson merged commit 0695ae1 into alan-turing-institute:python-migration Feb 8, 2024
9 checks passed
@JimMadge
Copy link
Member

JimMadge commented Feb 9, 2024

Can we make sure to get reviews for PRs before merging, even for small changes 🙏

@jemrobinson
Copy link
Member Author

Can we make sure to get reviews for PRs before merging, even for small changes 🙏

Sorry - my fault for trying to open too many PRs that all depended on one another! I'll try to restrain myself in future :)

@jemrobinson jemrobinson deleted the 1717-fix-containergroup-networkprofiles branch April 19, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants