Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor DSC fixes #1729

Conversation

jemrobinson
Copy link
Member

@jemrobinson jemrobinson commented Feb 5, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).
  • You have formatted your code using appropriate automated tools (for example ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory> for Powershell).

⤴️ Summary

Fixes to the SHM DSC that add a TestScript to SetAzureADSynchroniserPermissions in order to ensure that correct state is marked as "compliant" in the portal.

🌂 Related issues

🔬 Tests

Tested on a new SHM.

…t correct state is noted as such in the portal
@jemrobinson jemrobinson requested a review from a team February 5, 2024 13:09
@jemrobinson jemrobinson merged commit f14af3f into alan-turing-institute:python-migration Feb 5, 2024
9 checks passed
@jemrobinson jemrobinson deleted the fix-dsc-errors branch April 19, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant