Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump black version #1719

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Bump black version #1719

merged 1 commit into from
Jan 26, 2024

Conversation

JimMadge
Copy link
Member

@JimMadge JimMadge commented Jan 26, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).
  • You have formatted your code using appropriate automated tools (for example ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory> for Powershell).

⤴️ Summary

Update the minimum black version in line with the changes made in source.
Updating versions in pyproject.toml this way should prompt hatch to update packages in your environments.

@jemrobinson I did the same sort of thing recently when Ruff went to 0.1.0. Not sure if the versions on those tools should be more restrictive. In some way I like that linting breaking prompts you to update those dependencies. It does mean that CI can break and not be your fault though 🤔.

🌂 Related issues

Related to #1718

🔬 Tests

hatch run lint:all from a fresh env.

@JimMadge JimMadge requested a review from jemrobinson January 26, 2024 11:24
Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jemrobinson jemrobinson merged commit 81847af into python-migration Jan 26, 2024
9 checks passed
@jemrobinson jemrobinson deleted the black_version branch January 26, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants