Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues with context handling at deployment time #1716

Conversation

jemrobinson
Copy link
Member

@jemrobinson jemrobinson commented Jan 25, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).
  • You have formatted your code using appropriate automated tools (for example ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory> for Powershell).

⤴️ Summary

  • Add documentation about how to add a new SRE
  • Enable dsh config show to dump to a file
  • Raise exception if requested to deploy an SRE that does not have a config yet
  • Add Pydantic template for SREs
  • Add validation for SRE index (0-256 and unique)
  • Fix pytest exception changes

🌂 Related issues

See #1709

🔬 Tests

Tested on new SHM deployment

@jemrobinson jemrobinson force-pushed the 1709-fix-context-issues branch from ada436c to 4e5ec60 Compare January 25, 2024 12:22
data_safe_haven/commands/config.py Show resolved Hide resolved
data_safe_haven/config/config.py Show resolved Hide resolved
data_safe_haven/config/config.py Show resolved Hide resolved
@JimMadge JimMadge mentioned this pull request Jan 25, 2024
5 tasks
@jemrobinson jemrobinson requested a review from JimMadge January 25, 2024 15:59
@jemrobinson jemrobinson force-pushed the 1709-fix-context-issues branch from 2634442 to 53e422e Compare January 26, 2024 11:18
@jemrobinson jemrobinson force-pushed the 1709-fix-context-issues branch 2 times, most recently from 90fec91 to 5b0c746 Compare January 26, 2024 11:37
Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🎉.

Just a few questions.

Thanks for fixing all of my pytest.raise mistakes 🙏.

data_safe_haven/commands/deploy.py Outdated Show resolved Hide resolved
data_safe_haven/config/config.py Show resolved Hide resolved
data_safe_haven/config/config.py Show resolved Hide resolved
data_safe_haven/external/api/azure_cli.py Show resolved Hide resolved
@jemrobinson jemrobinson merged commit 66cd779 into alan-turing-institute:python-migration Jan 29, 2024
9 checks passed
@jemrobinson jemrobinson deleted the 1709-fix-context-issues branch April 19, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants