Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DBeaver drivers using Github workflow #1696

Merged

Conversation

craddm
Copy link
Contributor

@craddm craddm commented Jan 2, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).
  • You have formatted your code using appropriate automated tools (for example ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory> for Powershell).

⤴️ Summary

The current Github workflows do not actually update the DBeaver drivers, as the step where that happens uses the wrong update script. This fixes that problem.

🌂 Related issues

Closes #1695

🔬 Tests

@craddm craddm merged commit e3a2ea4 into alan-turing-institute:develop Jan 9, 2024
11 checks passed
@craddm craddm deleted the dbeaver-driver-workflow branch January 9, 2024 10:33
@JimMadge
Copy link
Member

JimMadge commented Jan 9, 2024

@craddm We should try manually triggering this to check that it does what we expect.

Looks like you already did #1698 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DBeaver driver versions not updating automatically
2 participants