Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out storage creation from SHM scripts #1673

Merged
merged 6 commits into from
Dec 1, 2023

Conversation

craddm
Copy link
Contributor

@craddm craddm commented Nov 27, 2023

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).
  • You have marked this pull request as a draft and added '[WIP]' to the title if needed (if you're not yet ready to merge).
  • You have formatted your code using appropriate automated tools (for example ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory> for Powershell).

⤴️ Summary

Moves the SHM storage account creation step into its own script, adds it as a step in the Deploy_SHM.ps1 script

🌂 Related issues

Closes #1366

🔬 Tests

Tested SHM deployment and storage account creation with new scripts.

Copy link
Member

@JimMadge JimMadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one comment about help text.

@craddm
Copy link
Contributor Author

craddm commented Nov 30, 2023

Looks good, one comment about help text.

I can't see any comments or changes requested

@JimMadge
Copy link
Member

🤦

@JimMadge JimMadge merged commit 2fc12d7 into alan-turing-institute:develop Dec 1, 2023
10 checks passed
@craddm craddm deleted the factor-storage branch December 12, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Factor out the creation of the storage account from the deployment script(s)
2 participants