-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all contributors table and instructions for how to update #1649
Add all contributors table and instructions for how to update #1649
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea (why haven't we done this already!?!).
If you install the CLI you should be able to test this locally.
Closing this for now as per Martin's comment on slack:
@JimMadge I guess if you were keen to have this then this can reopened later after a discussion with the team |
@edwardchalstrey1 Good point, the distinction between pinned actions and an unpinned bot is a little subtle but important. However, I think we can still use all contributors and should reopen this PR. We can commit to using the all contributors CLI to manager the contributors table. I think that is still better than what we currently do. Any workflows we could add to ensure consistency or try and spot missing contributors would be great. The contributing docs could be updated to say don't use the bot, but ask a maintainer. |
This reverts commit f2c1c27.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great.
A couple of things I think we should do,
- On the preview the contributors page appears under a "More" drop down in the menu bar. Can we make it more visible? Maybe there is a theme option for number of items before the drop down?
- I think we should take the approach of low threshold to contribution. There are more contribution types that we could acknowledge. Would you like me to have a go at updating the contributions?
- It would be worth asking in our Slack channels for contributors we might have missed. Especially contributions which don't appear in the commit history like funding, training, conversations, bug reports.
49bb961
to
8c992bd
Compare
I was unable to find GitHub accounts for some of the authors.
Done |
dfb8fb5
to
c371f31
Compare
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
.'[WIP]'
to the title if needed (if you're not yet ready to merge).Adds README table and badge, plus instructions that link to https://allcontributors.org/docs/en/cli/overview