Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create users with no password expiry on AD #1461

Merged
merged 1 commit into from
May 16, 2023

Conversation

craddm
Copy link
Contributor

@craddm craddm commented May 15, 2023

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the develop branch.
  • Your branch is up-to-date with the develop branch (you probably started your branch from develop but it may have changed since then).
  • If-and-only-if your changes are not yet ready to merge, you have marked this pull request as a draft pull request and added '[WIP]' to the title.
  • If-and-only-if you have changed any Powershell code, you have run the code formatter. You can do this with ./tests/AutoFormat_Powershell.ps1 -TargetPath <path to file or directory>.

⤴️ Summary

Changes the flag $PasswordNeverExpires to $True in the CreateUsers.ps1 script, so that users are created on the DC with the flag set, and preventing their password expiring on the local AD. This was causing log-in attempts on VMs to fail when the user's password was set over 90 days ago, despite still being able to log-in to the TRE in general.

🌂 Related issues

Closes #1443

🔬 Tests

I have tested the modified code on the currently deployed blue SHM.

@JimMadge JimMadge merged commit 50f8c70 into alan-turing-institute:develop May 16, 2023
@craddm craddm deleted the 1443-password-expiry branch May 19, 2023 11:28
@jemrobinson jemrobinson mentioned this pull request Aug 14, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password expiration can prevent Ubuntu VM log-in
2 participants