Add missing tests

tests_/config/conftest.py

@@ -0,0 +1,18 @@
+from pytest import fixture
+
+from data_safe_haven.config.context_settings import Context
+
+
+@fixture
+def context_dict():
+    return {
+        "admin_group_id": "d5c5c439-1115-4cb6-ab50-b8e547b6c8dd",
+        "location": "uksouth",
+        "name": "Acme Deployment",
+        "subscription_name": "Data Safe Haven (Acme)",
+    }
+
+
+@fixture
+def context(context_dict):
+    return Context(**context_dict)

tests_/config/test_config.py

@@ -0,0 +1,178 @@
+import pytest
+from pydantic import ValidationError
+from pytest import fixture
+
+from data_safe_haven.config.config import (
+    ConfigSectionAzure,
+    ConfigSectionPulumi,
+    ConfigSectionSHM,
+    ConfigSectionSRE,
+    ConfigSectionTags,
+    ConfigSubsectionRemoteDesktopOpts,
+)
+from data_safe_haven.utility.enums import DatabaseSystem, SoftwarePackageCategory
+from data_safe_haven.version import __version__
+
+
+class TestConfigSectionAzure:
+    def test_constructor(self):
+        ConfigSectionAzure(
+            admin_group_id="d5c5c439-1115-4cb6-ab50-b8e547b6c8dd",
+            location="uksouth",
+            subscription_id="d5c5c439-1115-4cb6-ab50-b8e547b6c8dd",
+            tenant_id="d5c5c439-1115-4cb6-ab50-b8e547b6c8dd",
+        )
+
+    def test_from_context(self, context):
+        azure_config = ConfigSectionAzure.from_context(
+            context=context,
+            subscription_id="d5c5c439-1115-4cb6-ab50-b8e547b6c8dd",
+            tenant_id="d5c5c439-1115-4cb6-ab50-b8e547b6c8dd",
+        )
+        assert azure_config.location == context.location
+
+
+class TestConfigSectionPulumi:
+    def test_constructor_defaults(self):
+        pulumi_config = ConfigSectionPulumi(encryption_key_version="lorem")
+        assert pulumi_config.encryption_key_name == "pulumi-encryption-key"
+        assert pulumi_config.stacks == {}
+        assert pulumi_config.storage_container_name == "pulumi"
+
+
+@fixture
+def shm_config():
+    return ConfigSectionSHM(
+        aad_tenant_id="d5c5c439-1115-4cb6-ab50-b8e547b6c8dd",
+        admin_email_address="admin@example.com",
+        admin_ip_addresses=["0.0.0.0"],  # noqa: S104
+        fqdn="shm.acme.com",
+        name="ACME SHM",
+        timezone="UTC",
+    )
+
+
+class TestConfigSectionSHM:
+    def test_constructor(self):
+        ConfigSectionSHM(
+            aad_tenant_id="d5c5c439-1115-4cb6-ab50-b8e547b6c8dd",
+            admin_email_address="admin@example.com",
+            admin_ip_addresses=["0.0.0.0"],  # noqa: S104
+            fqdn="shm.acme.com",
+            name="ACME SHM",
+            timezone="UTC",
+        )
+
+    def test_from_context(self, context):
+        shm_config = ConfigSectionSHM.from_context(
+            context=context,
+            aad_tenant_id="d5c5c439-1115-4cb6-ab50-b8e547b6c8dd",
+            admin_email_address="admin@example.com",
+            admin_ip_addresses=["0.0.0.0"],  # noqa: S104
+            fqdn="shm.acme.com",
+            timezone="UTC",
+        )
+        assert shm_config.name == context.shm_name
+
+    def test_update(self, shm_config):
+        assert shm_config.fqdn == "shm.acme.com"
+        shm_config.update(fqdn="modified")
+        assert shm_config.fqdn == "modified"
+
+    def test_update_validation(self, shm_config):
+        with pytest.raises(ValidationError) as exc:
+            shm_config.update(admin_email_address="not an email address")
+            assert "Value error, Expected valid email address" in exc
+            assert "not an email address" in exc
+
+
+@fixture
+def remote_desktop_config():
+    return ConfigSubsectionRemoteDesktopOpts()
+
+
+class TestConfigSubsectionRemoteDesktopOpts:
+    def test_constructor(self):
+        ConfigSubsectionRemoteDesktopOpts(allow_copy=True, allow_paste=True)
+
+    def test_constructor_defaults(self):
+        remote_desktop_config = ConfigSubsectionRemoteDesktopOpts()
+        assert not all(
+            [remote_desktop_config.allow_copy, remote_desktop_config.allow_paste]
+        )
+
+    def test_update(self, remote_desktop_config):
+        assert not all(
+            [remote_desktop_config.allow_copy, remote_desktop_config.allow_paste]
+        )
+        remote_desktop_config.update(allow_copy=True, allow_paste=True)
+        assert all(
+            [remote_desktop_config.allow_copy, remote_desktop_config.allow_paste]
+        )
+
+
+class TestConfigSectionSRE:
+    def test_constructor(self, remote_desktop_config):
+        sre_config = ConfigSectionSRE(
+            databases=[DatabaseSystem.POSTGRESQL],
+            data_provider_ip_addresses=["0.0.0.0"],  # noqa: S104
+            index=0,
+            remote_desktop=remote_desktop_config,
+            workspace_skus=["Standard_D2s_v4"],
+            research_user_ip_addresses=["0.0.0.0"],  # noqa: S104
+            software_packages=SoftwarePackageCategory.ANY,
+        )
+        assert sre_config.data_provider_ip_addresses[0] == "0.0.0.0/32"
+
+    def test_constructor_defaults(self, remote_desktop_config):
+        sre_config = ConfigSectionSRE(index=0)
+        assert sre_config.databases == []
+        assert sre_config.data_provider_ip_addresses == []
+        assert sre_config.remote_desktop == remote_desktop_config
+        assert sre_config.workspace_skus == []
+        assert sre_config.research_user_ip_addresses == []
+        assert sre_config.software_packages == SoftwarePackageCategory.NONE
+
+    def test_all_databases_must_be_unique(self):
+        with pytest.raises(ValueError) as exc:
+            ConfigSectionSRE(
+                index=0,
+                databases=[DatabaseSystem.POSTGRESQL, DatabaseSystem.POSTGRESQL],
+            )
+            assert "all databases must be unique" in exc
+
+    def test_update(self):
+        sre_config = ConfigSectionSRE(index=0)
+        assert sre_config.databases == []
+        assert sre_config.data_provider_ip_addresses == []
+        assert sre_config.workspace_skus == []
+        assert sre_config.research_user_ip_addresses == []
+        assert sre_config.software_packages == SoftwarePackageCategory.NONE
+        sre_config.update(
+            data_provider_ip_addresses=["0.0.0.0"],  # noqa: S104
+            databases=[DatabaseSystem.MICROSOFT_SQL_SERVER],
+            workspace_skus=["Standard_D8s_v4"],
+            software_packages=SoftwarePackageCategory.ANY,
+            user_ip_addresses=["0.0.0.0"],  # noqa: S104
+        )
+        assert sre_config.databases == [DatabaseSystem.MICROSOFT_SQL_SERVER]
+        assert sre_config.data_provider_ip_addresses == ["0.0.0.0/32"]
+        assert sre_config.workspace_skus == ["Standard_D8s_v4"]
+        assert sre_config.research_user_ip_addresses == ["0.0.0.0/32"]
+        assert sre_config.software_packages == SoftwarePackageCategory.ANY
+
+
+class TestConfigSectionTags:
+    def test_constructor(self):
+        tags_config = ConfigSectionTags(deployment="Test Deployment")
+        assert tags_config.deployment == "Test Deployment"
+        assert tags_config.deployed_by == "Python"
+        assert tags_config.project == "Data Safe Haven"
+        assert tags_config.version == __version__
+
+    def test_from_context(self, context):
+        tags_config = ConfigSectionTags.from_context(context)
+        assert tags_config.deployment == "Acme Deployment"
+        assert tags_config.deployed_by == "Python"
+        assert tags_config.project == "Data Safe Haven"
+        assert tags_config.version == __version__