Performance improvements #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix reduces runtime on the integration test set by ~17%.
Gives a speed improvement of ~15%
Rest might be feasible too, but may need some further investigation
The one file moving from error to failed is because the dialect detection fails, but it no longer times out due to the recent speed improvements. The failure can be investigated at some point, but is not considered urgent at this time.
Used to further test the c version of merge_with_quotechar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds performance improvements in two ways:
is_potential_escapecharfunction resultmerge_with_quotecharin CEspecially for large files, this will likely make a significant difference to the performance of CleverCSV. Some statistics(*) on our integration tests:
Also, this PR fixes the documentation error reported in #91.
*: one file (13a6c86a18f053c593feda3d98755010) was discarded from the comparison because before these improvement dialect detection would timeout, so it wasn't included previously.